Search found 8 matches

by fpdave100
Wed 04 Aug 2021 09:12
Forum: Review Assistant
Topic: Review changesets from WI is v slow - Minutes!!
Replies: 3
Views: 65430

Re: Review changesets from WI is v slow - Minutes!!

Hi, has any work been done to resolve this issue as it is still causing me major issues (VS2017 hanging and needing to be killed).
I cant use VS2019 because the feature to review a WI (multiple changesets) is not available despite the documentation!
by fpdave100
Wed 09 Dec 2020 15:23
Forum: Review Assistant
Topic: Is it possible to set/fix the order of the review comments
Replies: 5
Views: 54588

Is it possible to set/fix the order of the review comments

If some one wants to work thru the files in some order it makes it very difficult as the review comments are not listed in the same order as the files.

Perhaps when selecting a file, it could show (highlight, move to the top, optional hide others) existing review comments against that file. This would also stop duplicate review comments being added.
by fpdave100
Tue 22 Sep 2020 07:33
Forum: Review Assistant
Topic: Review Work Item Code missing in VS2019
Replies: 7
Views: 152259

Re: Review Work Item Code missing in VS2019

That just gets me the ability to view WIs in VS2019
but it doesnt enable the ability to start a review from that WI, which is what we are really needing (or a good workaround in the reviews dashboard)
by fpdave100
Thu 27 Aug 2020 11:52
Forum: Review Assistant
Topic: Review Work Item Code missing in VS2019
Replies: 7
Views: 152259

Re: Review Work Item Code missing in VS2019

Is there any progress on this in the latest code reviews. The code review website states:
"Two modes of opening Work Item
We supported two modes of opening a work item the same way as in Visual Studio: both in Visual Studio editor and in a web browser by default. For Visual Studio 2017 and lower, the opening mode is automatically detected depending on the studio settings. Visual Studio 2019 supports only the new behavior – opening in a web browser."

How do I do this from the web browser?
by fpdave100
Fri 17 Apr 2020 15:01
Forum: Code Compare
Topic: Anyway to manually adjust compare line syncing
Replies: 1
Views: 19496

Anyway to manually adjust compare line syncing

eg, I have:

Code: Select all

foo()
{
[b]XX[/b]
YY
ZZ
}
and a developer comes and changes it to be:
foo()
{
if (something)
{
XXX
YY
ZZZ
}
else
{
[b]XX[/b]
YY
ZZ
}
}
I'd like to be able to adjust the comparison so that the 2 bold lines are compared, but I cant do this. Is it posisble?
by fpdave100
Fri 17 Apr 2020 10:08
Forum: Review Assistant
Topic: Review Work Item Code missing in VS2019
Replies: 7
Views: 152259

Re: Review Work Item Code missing in VS2019

Losing this functionality in VS2019 is a major pain and will cause me to have an instance of VS2017 up all the time when doing reviews!

I have in front of me a WI with 8 changesets by 2 different people. Creating a review of that by adding changsets to a review will be a pain!

There should be a way to do this, even if initially it is just on teh Review Board itself - a "Create Review from WI" menu option.
by fpdave100
Fri 11 Oct 2019 15:12
Forum: Review Assistant
Topic: Review changesets from WI is v slow - Minutes!!
Replies: 3
Views: 65430

Review changesets from WI is v slow - Minutes!!

from within VS2017, I view a WI with changesets
I then right click the wi and select "Review Work Item Code"
sometimes this can then take 5+ minutes t come back, even with a WI with just a few changesets and a small number of files.

sometimes its fast enough, but sometimes it seems horrendously slow for every WI!

If its taken a long time and I chose the same operation (WI) again, then often it is immediate.
but other WIs will be slow to review.
VS is effectively hung whilst this is happening!
we are on TFS (15.117.27024.0)
by fpdave100
Wed 09 May 2018 11:46
Forum: Review Assistant
Topic: added files cant be viewed
Replies: 2
Views: 24752

added files cant be viewed

When a review has new files added, what ever options (under Advanced submenu) I try I get errors like:
--------------------------------
Review Assistant
--------------------------------
Error while getting the file revision from the repository.

Possible causes:
1. File was removed or renamed in an earlier revision.
2. Review had been created before the file was committed to the repository.
--------------------------------
OK
--------------------------------

and cannot view the file.

we are using:
  • RA 3.6.465
  • TFS
  • VS 2017
  • Devart Code Compare (free!)
viewing of existing files is fine

Edit>
If I do "open containing folder" against one of these new files I get:
--------------------------------
Review Assistant
--------------------------------
The specified folder doesn't exist:

C:\TFS\<TFS BRanch>\Release Instructions\Dev Next
--------------------------------
OK
--------------------------------

which doesnt exist on my machine - it should get these files from TFS surely

Edit (more info)>
some new files work!
It might be that new files under a TFS branch are visible, but that files in a folder under a TFS project do not work.

eg
$/<project>/<branch>/folder/newfile.sql would work,
$/<project>/folder/newfile.sql would not work.

We place some files not under a branch, for various reasons (eg deployment scripts).